feat(alerting): pushover priority on resolved #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Buhl <[email protected]>
onedr0p
commented
Oct 17, 2024
onedr0p
commented
Oct 17, 2024
Contributor
Author
|
I'm also fine with changing |
TwiN
requested changes
Oct 20, 2024
Contributor
Author
|
I went ahead and renamed this setting to |
onedr0p
commented
Oct 20, 2024
onedr0p
commented
Oct 21, 2024
TwiN
requested changes
Nov 5, 2024
Owner
TwiN
left a comment
TwiN
left a comment
There was a problem hiding this comment.
Looks like you forgot to update the tests
Signed-off-by: Devin Buhl <[email protected]>
Contributor
Author
|
@TwiN Updated, I added a condition for resolved-priority too. |
Signed-off-by: Devin Buhl <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
==========================================
+ Coverage 77.59% 77.61% +0.01%
==========================================
Files 72 72
Lines 5775 5784 +9
==========================================
+ Hits 4481 4489 +8
- Misses 1078 1079 +1
Partials 216 216 ☔ View full report in Codecov by Sentry. |
TwiN
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The logic can be handle a number of different ways, please advise if this solution is not ideal. Thanks!
#767
Checklist
README.md, if applicable.