-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add image labels, merge publish to Docker Hub/GHCR workflows #954
ci: Add image labels, merge publish to Docker Hub/GHCR workflows #954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for the contribution!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
=======================================
Coverage 76.04% 76.04%
=======================================
Files 74 74
Lines 6704 6704
=======================================
Hits 5098 5098
Misses 1304 1304
Partials 302 302 ☔ View full report in Codecov by Sentry. |
@tigattack Hmm, do you have any idea why, when I
P.S. This was from the publish-experimental workflow, not the publish-latest or publish-release workflows. |
@TwiN it seems like the |
Ah good point, I forgot the experimental image was on a much older branch 🤦 |
No worries, glad I could help 😄 |
Just to confirm, all good with the latest "Labels": {
"org.opencontainers.image.created": "2025-01-08T03:27:00.063Z",
"org.opencontainers.image.description": "⛑ Automated developer-oriented status page",
"org.opencontainers.image.licenses": "Apache-2.0",
"org.opencontainers.image.revision": "c259364edf0f2edb2ac93db1256b1ad5a1a8992e",
"org.opencontainers.image.source": "https://github.com/TwiN/gatus",
"org.opencontainers.image.title": "gatus",
"org.opencontainers.image.url": "https://github.com/TwiN/gatus",
"org.opencontainers.image.version": "latest"
} |
Summary
This PR merges the currently separate workflows for publishing to Docker Hub and GHCR. It also adds labels to the built images as a good best-practice enhancement.
My personal motivation for this was originally adding labels to allow Renovate to track the origin of an update to the image in my repo and embed changelogs. It's able to do this thanks to the standardised OCI labels which this PR adds.
Whilst doing this, I thought a nice enhancement would be to merge the separate workflows for Docker Hub/GHCR pushes, since I couldn't see a reason for their separation. Let me know if I've missed a use case for this or the change is otherwise undesirable, and I can strip this PR back to just add labels to built images.
Example of generated labels in the context of the
publish-release
workflow:And an example of generated tags in the same context:
Checklist
README.md
, if applicable.