Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Add support for SNI override #958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlisonT1230
Copy link

@AlisonT1230 AlisonT1230 commented Jan 7, 2025

Summary

Add ability to explicitly set SNI for HTTPS and TLS endpoint monitoring.

Note:

  • The logic around checking if a TLS config exists has been modified in this PR. Previously, it required the presence of the client certificate & key. This PR changes it to check just for existence of client.tls field in order to make room for configuring SNI without needing to provide a client certificate & key.
  • Updated the MTLS docker compose example to make use of the sample certs in that folder so there's a setup that is able to do secure mTLS connection. The gatus spun up in the environment is rewrapped such that it expects those test certificates as a valid CA.

related to #907

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@AlisonT1230 AlisonT1230 marked this pull request as ready for review January 7, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant