Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10891 Remove TYK_GW_POLICIES_RECORD_NAME #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djablonski-moia
Copy link
Contributor

@djablonski-moia djablonski-moia commented Dec 22, 2023

With this value set, policies can't be created via the API, nor are others used when added as files. According to this community support request / answer, this configuration option is legacy anyway for a long time already.

Description

Removed the (legacy) TYK_GW_POLICIES_RECORD_NAME env variable for configurations without remoteControlPlane enabled (haven't tested in such an environment, therefore not changing it there).

Related Issue

Motivation and Context

We had the problem that policies were not found/created, and searching brought up this community request/response, and removing the env variable immediately fixed the issue.

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

With this value set, policies can't be created via the API, nor are others used when added as files.
According to [this community support request / answer](https://community.tyk.io/t/list-policies-returning-incorrect-policies/5625/4), this configuration option is legacy anyway for a long time already.
@djablonski-moia djablonski-moia requested a review from a team as a code owner December 22, 2023 07:44
@djablonski-moia djablonski-moia requested review from komalsukhani and removed request for a team December 22, 2023 07:44
@djablonski-moia
Copy link
Contributor Author

I'm unsure about the tests mentioned in the PR template, haven't seen any for the charts 🤔

@caroltyk caroltyk changed the title Remove TYK_GW_POLICIES_RECORD_NAME TT-10891 Remove TYK_GW_POLICIES_RECORD_NAME Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant