Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-13615] Add imageRegistry #361

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[TT-13615] Add imageRegistry #361

wants to merge 8 commits into from

Conversation

zalbiraw
Copy link
Member

@zalbiraw zalbiraw commented Nov 20, 2024

Description

As a user I would like to set the imageRegistry for all my containers

This removes docker.tyk.io from gateway and pump containers. It can readded as if statement but I dont know if we track this anymore. Maybe there should be a different way to track things.

This feature is required for enterprise deployments where the users have their own registry.

Changes ported to operator chart
https://github.com/TykTechnologies/tyk-operator-internal/pull/98

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner November 20, 2024 22:01
@zalbiraw zalbiraw requested review from buraksekili and removed request for a team November 20, 2024 22:01
@zalbiraw zalbiraw changed the title Add imageRegistry [TT-13615] Add imageRegistry Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant