You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6486)
* Testing removing existing Cookie and adding Cookiebot - note using test GTM at the moment do not out live
* switching to production GTM
* removing old files and references to them
---------
Co-authored-by: Leonid Bugaev <[email protected]>
(cherry picked from commit 0dd3b7d)
The removal of conditional GTM loading based on cookie consent means GTM will always load, which may have privacy or compliance implications. Review if this aligns with current privacy requirements.
<!-- Google Tag Manager --><script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
newDate().getTime(),event:'gtm.js'});varf=d.getElementsByTagName(s)[0],j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src='https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);})(window,document,'script','dataLayer','GTM-NVX4PCL');</script><!-- End Google Tag Manager -->
The legacy cookie notice partial and related scripts have been removed. Confirm that this does not break any required user notifications or compliance obligations.
Loading Google Tag Manager without user consent may violate privacy regulations. Consider restoring a consent check before initializing GTM to avoid tracking users who have not opted in.
-<script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':-new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],-j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=-+'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);-})(window,document,'script','dataLayer','GTM-NVX4PCL');</script>+<script>+ if (!localStorage.getItem("cookieDisabled")) {+ (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':+ new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],+ j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=+ 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);+ })(window,document,'script','dataLayer','GTM-NVX4PCL');+ }+</script>
Suggestion importance[1-10]: 9
__
Why: This suggestion addresses a critical privacy and compliance issue by restoring a user consent check before loading Google Tag Manager, which is essential for adhering to privacy regulations and respecting user choices.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Testing removing existing Cookie and adding Cookiebot - note using te… (#6486)
Testing removing existing Cookie and adding Cookiebot - note using test GTM at the moment do not out live
switching to production GTM
removing old files and references to them
Co-authored-by: Leonid Bugaev [email protected]
PR Type
Enhancement
Description
Removed legacy cookie notice and related scripts
Updated Google Tag Manager (GTM) to always load asynchronously
Simplified GTM logic by removing cookie consent checks
Updated GTM container ID usage for consistency
Changes walkthrough 📝
cookie.js
Remove cookie consent JavaScript logic
tyk-docs/static/js/cookie.js
baseof.html
Remove cookie notice and update GTM noscript
tyk-docs/themes/tykio/layouts/_default/baseof.html
cookie_notice.html
Delete cookie notice HTML partial
tyk-docs/themes/tykio/layouts/partials/cookie_notice.html
head_tracking.html
Simplify and always-enable GTM script loading
tyk-docs/themes/tykio/layouts/partials/head_tracking.html