fix: File resize UX #1223
Open
fix: File resize UX #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
requested changes
Nov 14, 2024
| @@ -57,6 +57,17 @@ export const imageRender = ( | |||
| block: BlockFromConfig<typeof imageBlockConfig, any, any>, | |||
| editor: BlockNoteEditor<any, any, any> | |||
| ) => { | |||
| // Immediately updates & re-renders the block if it's wider than the editor. | |||
| if ( | |||
There was a problem hiding this comment.
My first feeling is I don't really like this approach:
- what if a user opens the document on a small screen, and later on a large screen?
- what if the user is in read-only mode?
| @@ -372,20 +373,19 @@ NESTED BLOCKS | |||
| height: 24px; | |||
| } | |||
|
|
|||
| [data-file-block] .bn-visual-media-wrapper { | |||
| [data-file-block] .bn-resize-handles-wrapper { | |||
There was a problem hiding this comment.
make sure DO etc isn't using the old classnames. I suppose you didn't like the earlier name / just a cleanup right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 bugs regarding file resize UX:
TODO:
Currently unit tests fail as something is going wrong when calling
updateBlockon the initial render.getBlockFromPosis throwing an error asgetPos()returns 0.An alternative approach I got working was to check whether the default
previewWidthis higher than the editor width when a file is initially added. However, that approach doesn't fix the case where the editor initial contents have a file that is too wide. So I think checking the width on update is the only solution that covers all cases.