fix: Clipboard insertion with multiple data types #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
requested changes
Nov 12, 2024
YousefED
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when inserting content from the clipboard, we prioritize files over text. However, this is problematic in some cases, such as when copy/pasting Excel tables. In this scenario, the table is written to
text/htmland an image of the table is written toFileson the clipboard. So previously, an image block was created and in this PR, the table block is created instead.There may be other cases in which we actually do want to prioritize files over text, but I'm not sure atm. This is not relevant for pasting/dropping files from the user's OS file system as in that case, data is only written to
Fileson the clipboard so the priority doesn't matter.