-
-
Notifications
You must be signed in to change notification settings - Fork 538
chore: add style exports for all stylesheets #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@RobinClowers is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
Hi @RobinClowers I missed this one. Could you expand a bit on why you need it to be part of the In my understanding, you should be able to point to the file you need directly as a relative path, are you maybe trying to have it be a bit more pleasant by allowing it to just be |
@nperez0111 no problem, thanks for getting back to me. Specifically this line from the postcss-import docs is relevant:
I want to be able to do this: @import "@blocknote/core/style.css" layer(components); Which scopes the styles in the components layer, allowing tailwind utilities to override them (because of the layer order, the utility layer has a higher precedence than components). To your point, I suppose I could import directly from the path, e.g. Is there some downside to exposing these exports? |
Ah, that is what I missed. Alright, I'm on board with this change. I know this is minor but, could move the |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-docx-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
6ecb6e8
to
f701658
Compare
f701658
to
6b0df20
Compare
Sure thing, rebased on the latest main and moved the exports to the end. |
When I tried to install the PR package, I ran into this:
Not sure if this is something specific to bun, I've never used pgk.pr.new. |
Yea, with the pkg.pr.new, since the packages depend on each other, you may need to force the versions to resolve to the pkg.pr.new versions instead using an override. |
@nperez0111 I was able to test this and it worked for me, it's good to merge from my perspective. |
Thanks for the contribution @RobinClowers |
Adds style exports for all stylesheets, so they can be imported by postcss / tailwind.
When upgrading to tailwind 4, we ran into an issue where our tailwind utility classes suddenly couldn't override blocknote styles anymore. This turns out to be related to css layers. It's easy to solve by importing the styles in css (where we can assign them a layer), but unfortunately it's not possible without these style exports.
See https://github.com/postcss/postcss-import for more details.