refactor: zod poc #1724
Draft
refactor: zod poc #1724
+402
−459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
reviewed
May 29, 2025
| }) | ||
| .extend({ | ||
| // File name. | ||
| name: z.string().default(""), |
There was a problem hiding this comment.
Maybe we want to do meta descriptions: https://zod.dev/metadata#meta
nperez0111
reviewed
Jun 5, 2025
| @@ -10,15 +10,15 @@ export const BackgroundColorExtension = Extension.create({ | |||
| types: ["blockContainer", "tableCell", "tableHeader"], | |||
| attributes: { | |||
| backgroundColor: { | |||
| default: defaultProps.backgroundColor.default, | |||
| default: defaultProps.shape.backgroundColor._zod.def.defaultValue, | |||
There was a problem hiding this comment.
I don't really like reaching into what feels like an internal value for this, is there another way of doing it that is part of the public API?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC to use Zod instead of our custom schema language for block and inline content props. Let's discuss if this is a direction we want to take. If so, we should:
coreandtestspass!createReactBlockSpecto a Zod schemathanks @aeplay for mentioning this in your talk 😂
closes #444