Skip to content

Add property implications #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Add property implications #12

merged 2 commits into from
May 7, 2025

Conversation

mfasi
Copy link
Collaborator

@mfasi mfasi commented Mar 31, 2025

No description provided.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/matrices/cauchy.jl 100.00% <ø> (ø)
src/matrices/chow.jl 100.00% <ø> (ø)
src/matrices/circulant.jl 100.00% <ø> (ø)
src/matrices/clement.jl 100.00% <ø> (ø)
src/matrices/companion.jl 100.00% <ø> (ø)
src/matrices/comparison.jl 100.00% <ø> (ø)
src/matrices/cycol.jl 100.00% <ø> (ø)
src/matrices/dingdong.jl 100.00% <ø> (ø)
src/matrices/dorr.jl 100.00% <ø> (ø)
src/matrices/dramadah.jl 100.00% <ø> (ø)
... and 46 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mfasi mfasi changed the title Add property implications (WIP) Add property implications Mar 31, 2025
@mfasi mfasi requested a review from AnzhiZhang March 31, 2025 12:13
@mfasi mfasi force-pushed the dev branch 2 times, most recently from 1f83b4c to eb43ca4 Compare April 1, 2025 12:15
@AnzhiZhang
Copy link
Collaborator

AnzhiZhang commented Apr 28, 2025

Should the list of properties in doc be updated as well?

https://github.com/TypedMatrices/TypedMatrices.jl/blob/master/docs/src/references/3.properties.md

New list:

TypedMatrices.PropertyTypes.Bidiagonal
TypedMatrices.PropertyTypes.Binary
TypedMatrices.PropertyTypes.Circulant
TypedMatrices.PropertyTypes.Complex
TypedMatrices.PropertyTypes.Correlation
TypedMatrices.PropertyTypes.Defective
TypedMatrices.PropertyTypes.DiagonallyDominant
TypedMatrices.PropertyTypes.Eigensystem
TypedMatrices.PropertyTypes.FixedSize
TypedMatrices.PropertyTypes.Graph
TypedMatrices.PropertyTypes.Hankel
TypedMatrices.PropertyTypes.Hermitian
TypedMatrices.PropertyTypes.Hessenberg
TypedMatrices.PropertyTypes.IllConditioned
TypedMatrices.PropertyTypes.Indefinite
TypedMatrices.PropertyTypes.InfinitelyDivisible
TypedMatrices.PropertyTypes.Integer
TypedMatrices.PropertyTypes.Inverse
TypedMatrices.PropertyTypes.Involutory
TypedMatrices.PropertyTypes.Nilpotent
TypedMatrices.PropertyTypes.Nonnegative
TypedMatrices.PropertyTypes.Normal 
TypedMatrices.PropertyTypes.Orthogonal
TypedMatrices.PropertyTypes.Positive
TypedMatrices.PropertyTypes.PositiveDefinite
TypedMatrices.PropertyTypes.PositiveSemidefinite
TypedMatrices.PropertyTypes.Random
TypedMatrices.PropertyTypes.RankDeficient
TypedMatrices.PropertyTypes.Rectangular
TypedMatrices.PropertyTypes.RegularisationProblem
TypedMatrices.PropertyTypes.SingularValues
TypedMatrices.PropertyTypes.Sparse
TypedMatrices.PropertyTypes.Symmetric
TypedMatrices.PropertyTypes.Triangular
TypedMatrices.PropertyTypes.Tridiagonal
TypedMatrices.PropertyTypes.Toeplitz
TypedMatrices.PropertyTypes.TotallyNonnegative
TypedMatrices.PropertyTypes.TotallyPositive
TypedMatrices.PropertyTypes.Unimodular
TypedMatrices.PropertyTypes.Unitary

@mfasi
Copy link
Collaborator Author

mfasi commented Apr 29, 2025

Should the list of properties in doc be updated as well?

https://github.com/TypedMatrices/TypedMatrices.jl/blob/master/docs/src/references/3.properties.md

New list:

TypedMatrices.PropertyTypes.Bidiagonal
TypedMatrices.PropertyTypes.Binary
TypedMatrices.PropertyTypes.Circulant
TypedMatrices.PropertyTypes.Complex
TypedMatrices.PropertyTypes.Correlation
TypedMatrices.PropertyTypes.Defective
TypedMatrices.PropertyTypes.DiagonallyDominant
TypedMatrices.PropertyTypes.Eigensystem
TypedMatrices.PropertyTypes.FixedSize
TypedMatrices.PropertyTypes.Graph
TypedMatrices.PropertyTypes.Hankel
TypedMatrices.PropertyTypes.Hermitian
TypedMatrices.PropertyTypes.Hessenberg
TypedMatrices.PropertyTypes.IllConditioned
TypedMatrices.PropertyTypes.Indefinite
TypedMatrices.PropertyTypes.InfinitelyDivisible
TypedMatrices.PropertyTypes.Integer
TypedMatrices.PropertyTypes.Inverse
TypedMatrices.PropertyTypes.Involutory
TypedMatrices.PropertyTypes.Nilpotent
TypedMatrices.PropertyTypes.Nonnegative
TypedMatrices.PropertyTypes.Normal 
TypedMatrices.PropertyTypes.Orthogonal
TypedMatrices.PropertyTypes.Positive
TypedMatrices.PropertyTypes.PositiveDefinite
TypedMatrices.PropertyTypes.PositiveSemidefinite
TypedMatrices.PropertyTypes.Random
TypedMatrices.PropertyTypes.RankDeficient
TypedMatrices.PropertyTypes.Rectangular
TypedMatrices.PropertyTypes.RegularisationProblem
TypedMatrices.PropertyTypes.SingularValues
TypedMatrices.PropertyTypes.Sparse
TypedMatrices.PropertyTypes.Symmetric
TypedMatrices.PropertyTypes.Triangular
TypedMatrices.PropertyTypes.Tridiagonal
TypedMatrices.PropertyTypes.Toeplitz
TypedMatrices.PropertyTypes.TotallyNonnegative
TypedMatrices.PropertyTypes.TotallyPositive
TypedMatrices.PropertyTypes.Unimodular
TypedMatrices.PropertyTypes.Unitary

Good point – I missed this in this PR, and fixed it in a successive commit in #13.

@AnzhiZhang AnzhiZhang merged commit 1482aed into master May 7, 2025
5 checks passed
@AnzhiZhang AnzhiZhang deleted the dev branch May 7, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants