Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving local dev and testing #120

Merged
merged 2 commits into from
Oct 1, 2024
Merged

improving local dev and testing #120

merged 2 commits into from
Oct 1, 2024

Conversation

acholyn
Copy link
Collaborator

@acholyn acholyn commented Sep 30, 2024

Adding conditional to email mixin to stop error on local about not being able to connect to aws - triggered when saving and deleting film instances. Also applied to the s3 browser button

@acholyn acholyn added the QoL improvement makes our lives easier label Sep 30, 2024
@acholyn acholyn requested a review from tcouch September 30, 2024 12:04
Copy link
Collaborator

@tcouch tcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I encountered this problem when testing film sorting but didn't realise this was the cause.

@acholyn acholyn merged commit a0f51bc into development Oct 1, 2024
3 checks passed
@acholyn acholyn deleted the improving-local branch October 3, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QoL improvement makes our lives easier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants