Fixing popout on aws not finding static files #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcouch
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Looks good.
One small thing: because this PR includes the changes made to Visual and Written influences it's harder to see what changes you've made specifically for the popout. Would have been better to either branch off development, or point this PR to the V&WI branch.
Co-authored-by: Tom Couch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access the correct staticurl via
editor.configin the popout plugin, this should be set in theCKEDITOR_CONFIGSin settings. Should work dynamically