Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PDF webview component #87

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Fix PDF webview component #87

merged 3 commits into from
Jan 20, 2025

Conversation

tamuri
Copy link
Collaborator

@tamuri tamuri commented Jan 20, 2025

Fixes #84

  • Move the PDF.js assets into the src directory.
  • Fix the paths to pdf.js viewer and use the absolute path to candidate files

@shiyingwucl
Copy link
Collaborator

Thanks for the fix - Should I merge this?

@tamuri
Copy link
Collaborator Author

tamuri commented Jan 20, 2025

Yes, please.

@shiyingwucl shiyingwucl merged commit 168f88c into UCL-ARC:main Jan 20, 2025
2 checks passed
@tamuri tamuri deleted the tamuri/fix-webview branch January 20, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webview error on fresh installation
2 participants
@tamuri @shiyingwucl