Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database subnet #62

Closed
p-j-smith opened this issue Aug 10, 2023 · 1 comment · Fixed by #63
Closed

Remove database subnet #62

p-j-smith opened this issue Aug 10, 2023 · 1 comment · Fixed by #63
Assignees

Comments

@p-j-smith
Copy link
Contributor

p-j-smith commented Aug 10, 2023

I think we don't need both the private and database subnets - the database subnet can be used to expose the database to the public, but is not recommended.

We could create our own aws_db_subnet_group (using the private subnets), and use this when creating the RDS instance

@p-j-smith p-j-smith self-assigned this Aug 10, 2023
@milanmlft
Copy link
Collaborator

I agree we don't need them. The only reason I added them is because the setup_vpc module failed when only enabling database_subnets without any private subnets. See terraform-aws-modules/terraform-aws-vpc#944.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants