Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove database subnet and add architecture diagram #63

Merged
merged 10 commits into from
Aug 10, 2023
Merged

Remove database subnet and add architecture diagram #63

merged 10 commits into from
Aug 10, 2023

Conversation

p-j-smith
Copy link
Contributor

Fixes #42
Fixes #62

  • remove the database subnet and use only the private one. Create our own aws_db_subnet_group rather than using the setup_vpc module do it - this way we can put the private subnet ids in the group
  • explicitly set the availability to put the RDS instance in (otherwise it will randomly choose)
  • add a diagram of the infrastructure we're creating
  • add some notes on the infrastructure / resources we're creating

@p-j-smith p-j-smith requested a review from milanmlft August 10, 2023 14:15
milanmlft
milanmlft approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good! Thanks for adding more details regarding the Terraform setup.
Just a small suggestion to remove the now obsolete comment regarding database subnets.

assets/xnat-aws-architecture.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't ask how long this took 😂

provision/main.tf Outdated Show resolved Hide resolved
@p-j-smith p-j-smith merged commit d64ae2b into main Aug 10, 2023
@HChughtai HChughtai deleted the aws-architecture-diagram branch June 29, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanmlft milanmlft milanmlft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove database subnet Add diagram to show AWS infrastructure layout
2 participants
@p-j-smith @milanmlft