Merged
Conversation
src/utilities/SSRB.cxx: formatting of help doc-string
Contributor
Author
|
Checks have been performed by mashing uniform 1 sinograms:
|
Collaborator
|
This looks good to me, but weirdly enough it seems like we broke |
This results in shorter code, but also consistent. There was a "problem" in the previous version that the TOF bin was actually used as tang_pos_num when determining get_m() (but it didn't create a problem as currently get_m() in independent of both).
even if do_norm=1, we should not normalise with the number of TOF bins. This is because the projectors will take the width of the TOF bin properly into account. (In contrast, for "span", they don't).
add a few arguments and configurable environment variables to be able to modify the output of the simulation
Using the cache has very little impact on run-time for a single forward projection, but affects memory a lot. This is especially important for TOF.
Collaborator
|
I had to undo the normalisation for "num_mashed_tof_bins". The projectors are set-up such that the total number of counts remains the same independent of number of TOF bins/width etc (i.e. the same as non-TOF). Therefore, when mashing TOF bins and setting I've now added a test to check all this via reconstruction. This should be good to go. Let's see how the tests are doing. |
When using a single int as argument, the old style version is actually not used anymore due to the overload with the verbosity presumably. So use boost::format
span=2, max_rd=2 is unexpected, and leads to a bug in FBP3DRP etc. Changing to the expected case of max_rd=3 for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Testing performed
Related issues
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)