-
Notifications
You must be signed in to change notification settings - Fork 16
Param Revamp - ALRI #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Param Revamp - ALRI #1730
Conversation
|
@marghe-molaro ready for review |
|
Hi @mmsuarezcosta, Many thanks for this! I believe all relevant hardcoded parameters have been removed (the few standing ones are more "by definition" anyway, so I'm flagging it as such in the overview file. For the parameters flagged as "undetermined"/"calibration", was this established via the write-up? I am not sure I am in a position to judge whether all those universal parameters can be labelled as such, I think this is @tbhallett's call! |
|
|
Hi @mmsuarezcosta thanks for the response! Another thing I wanted to check - I see you have deleted some of the files inside ResourceFile_Alri/ directory which weren't being used (will double check whether this is the protocol we actually want to follow vs storing elsewhere) Just wandering why GBD_Malawi_estimates.csv and McAllister_2019.csv were kept? I don't see them being called by the module itself |
@marghe-molaro thanks for the review. Regarding deleted files: |
Files
Deleted
Parameters
Note: There is discrepancy between the write-up and the parameter values on the CSV file (parameters names, list, values, ...)
Dummy/Assumed
I am documenting the following parameters in the CSV file that have been either marked as dummy or assumed :
prob_lung_abscess_in_pulmonary_complicated_pneumonia,prob_pneumothorax_in_pulmonary_complicated_pneumonia,prob_cough_in_other_alri,prob_difficult_breathing_in_other_alri,prob_chest_indrawing_in_other_alri,prob_danger_signs_in_sepsis,prob_iCCM_severe_pneumonia_treated_as_fast_breathing_pneumonia,prob_IMCI_severe_pneumonia_treated_as_non_severe_pneumoniaLocal v. Universal
prob) has been defined as universal. A recommended exercise will be to revisit toprobparameters and determine if any are local-specifictf) are assumed to be based on the true effect of the drug treatment, not on any location-specific factors (eg drug adherence) and thus are deemed to be universal.