Param Revamp - Postnatal Supervisor #1734
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters
Additional comment deleted (some params had values in addt notes not used)
weekly_prob_pre_eclampsia_pn: [0.0016, 0.0016]probs_for_mgh_matrix_pn: [[0.884, 0.066, 0.05, 0, 0], [0.884, 0.066, 0.05, 0, 0]]probs_for_mpe_matrix_pn: [[0, 0, 0.89, 0.11, 0], [0, 0, 0.89, 0.11, 0]]rr_secondary_pph_endometritis: Delete? (Did not delete this parameter, it is used inpostnatal_supervisor_lm.py)Undetermined, Design Decision
emergency_postnatal_care_reset_week(week == 6): Params reset at week 6 for women who are experiencing severe complications. Open discussion to a) revert to keeping this variable hard-coded as it is "by definition", b) update variable name if there is a specific logic for it that is more descriptive than 'reset', or c) accept new change as-ispostnatal_reset_week(week == 8): Same discussion and options as aboveweek_5_postnatal_neonatesas-is because seemed to be best categorized as option a in options aboveUndetermined, Calibration
In some instances, for Parameter X the column Source and/or relevant calculation, the text will state See (name of Parameter Y). In these cases, when Parameter Y is derived via calibration, my understanding is that the Parameter X is also derived from calibration. Is this interpretation correct? @joehcollins
Examples include:
prob_type_of_anaemia_pn: The write-up referencesbaseline_prob_anaemia_per_month, which is defined as being derived by calibration. The definition of this parameter itself states that it is calculated as "the proportion of pregnant women with mild/moderate/severe anaemia divided by the total proportion of pregnant women with any anaemia".cfr_secondary_postpartum_haemorrhage.cfr_secondary_postpartum_haemorrhagereferences the calibrated parameterprob_ectopic_pregnancy_death. This calibrated parameter has the following description:cfr_eclampsiacfr_severe_pre_eclampsia: Cannot find parameter in write-up, but assume that it was calibrated in same process ascfr_eclampsiaLocal v. Universal
It is a little grey differentiating local v. universal parameters in this module. Will be great to have developer input here. I am aiming to capture the essence of
When unsure, I have erred on the side of 'local'. I am documenting the params that are most important to review below
Local
prob_early_onset_neonatal_sepsis_week_1,prob_late_onset_neonatal_sepsis,_window_days, I am labeling as a local variable because it is based on local context how long appt can be scheduled for.Universal
rr_gest_htn_obesityrr_eonsortreatment_effect,
rr_gest_htn_obesity,rr_pre_eclampsia_obesity,rr_pre_eclampsia_diabetes_mellitusBased on assumptions (documenting here for future reference)
In the write-up, it states that there was no/limited data for these values, so they are assumptions
prob_htn_resolves, also taking this to be local bc I am assuming that there are local elements that are affecting this.prob_monthly_death_severe_htnweekly_prob_death_severe_gest_htn