Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files
Files containing parameters:
parameters.csv: Updated ✅MAP_ITNrates.csv: Updated ✅ (Doesn't have param_name, all other cols added)MAP_IRSrates.csv: Updated ✅ (Doesn't have param_name, all other cols added)WHO_TestData2023.csv- Param names are column headers. I simply added column name 'param_label' and defined as local. Future revision will require transposing the DF. @mnjowe I currently implemented a temp solution in the code. The test_analysis was failing at functionis_df_same_size_and_dtypebecause updated version of this df did not have theparam_label. I attempted debugging to determine where the update was happening. I did not find the source, and I have implemented this temp solution:highrisk_districts.csv: Not updated . Kept as-is. Two columns aredistrict(containing district name) anddistrict_num. No prior min/max applicable.scaleup_parameters.csv: Updated ✅ Changedtarget_valuetovaluefor consistency. Confirmation required if this change is OK.Not used in code , recommend deleting if legacy
-severe_symptoms.csv
Files continaing calibration data
(including MAP outputs -- uncertain if these values also contain model outputs)
Files not in folder ResourceFile_malaria
Local
temp_max_itn_coverage: Explained here. I decided to parameterize this since ITN coverage may vary across contexts, so can have higher/lower limits of what is 'normal'. It’s currently labeled as “temp” because it is a parameter that is used for code efficiency. Ideally this type of parameter could be removed and there are only parameters relating to the health system itself. Currently set to local, but not inherent to local context.
max_age_incidence_data: The maximum age for which incidence data is available — this is the upper threshold for who is considered "alive" in the module. It may be useful to extrapolate the rates for age 80+ to provide a more complete view of the population. Currently set to local, but not inherent to local context.p_sev_anaemia_preg: Probability of severe anaemia in pregnant women with malaria may depend on country-specific baseline anaemia ratesdata_end: Refers to the last date for which a given dataset provides data. Currently set to local, but not inherent to local context.Parameter Nomenclature Formatting
MalariaIPTp_frequency_months). Is this acceptable, or do all parameter names need to be lowercase?# check itn projected values are <=0.7 and rounded to 1dp for matching to incidence tablesI’ve replaced hardcoded values with parameter references for clarity:
# check itn projected values are <= temp_max_itn_coverage and rounded to 1dp for matching to incidence tablesIs this preferred formatting for readability?
Universal
dur_asym,dur_clin,dur_clin_para: These are based on studies conducted in African contexts, but since they reflect biological or clinical durations, I am labeling as universalAssumptions
dur_clin: Defined in write-up to be an assumptionAdditional Miscellaneous Notes
cfr_severe_malaria) and should be adjusted in the write-upprob_of_treatment_successis currently set to 1.