Add SDV as dependency and update requirements file #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @tamuri, unfortunately I get the following errors: sdv.errors.VersionError: You are currently on SDV version 1.20.1 but this synthesizer was created on version 1.22.1. Downgrading your SDV version is not supported. Attaching to this message the conda environment on which the emulator branch is currently working. |
Collaborator
Author
|
To confirm: the saved file was created using version 1.22.1 but the version you're running is 1.24.1? Meaning that newer version can read files created by an older version? |
Collaborator
Author
|
Pinned sdv to 1.24.1. Please try again @marghe-molaro. |
Collaborator
|
Confirming that this new environment is now working fine, many thanks @tamuri |
Collaborator
Author
|
Thanks for checking - please approve! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1755. I have avoided updating the other dependencies, especially numpy and pandas as these have big effect on the epi modules. However, had to update virtualenv because sdv requires a more recent version of platformdirs.
Also,
dev.txtis also constrained bybase.txtwhen using pip-compile to ensure consistency.@marghe-molaro - the resolved version of sdv (1.20.1) was the most recent that doesn't disturb the other packages. Can you check these requirement still work for your emulator, please? You can create a new conda environment to test.