making bib section view use related model + aligning templates with this

src/rard/research/urls.py

@@ -102,6 +102,7 @@
                     path(
                         "<pk>/bibliography/",
                         views.BibliographySectionView.as_view(),
+                        {"related_model": "antiquarian"},
                         name="bibliography",
                     ),
                     path(
@@ -662,6 +663,7 @@
                     path(
                         "<pk>/bibliography/",
                         views.BibliographySectionView.as_view(),
+                        {"related_model": "citing_author"},
                         name="bibliography",
                     ),
                     path(

src/rard/research/views/bibliography.py

@@ -13,6 +13,7 @@
 
 from rard.research.forms import BibliographyItemForm, BibliographyItemInlineForm
 from rard.research.models import Antiquarian, BibliographyItem
+from rard.research.models.citing_work import CitingAuthor
 from rard.research.views.mixins import CanLockMixin, CheckLockMixin
 
 
@@ -159,23 +160,34 @@ class BibliographyDeleteView(
 
 class BibliographySectionView(LoginRequiredMixin, PermissionRequiredMixin, ListView):
     model = BibliographyItem
-    template_name = "research/partials/antiquarian_bibliography_list.html"
     context_object_name = "bibliography_items"
     permission_required = ("research.view_bibliographyitem",)
 
-    # todo: update this to dynamically work with authors and ants
     def get_queryset(self) -> QuerySet[Any]:
         if self.model is not None:
             queryset = self.model._default_manager.all()
-        self.ant_pk = self.kwargs.get("pk")
-        if self.ant_pk:
-            queryset = queryset.filter(antiquarians__id=self.ant_pk)
+        self.owner_pk = self.kwargs.get("pk")
+        related_model = self.kwargs.get("related_model")
+        if self.owner_pk:
+            # use related_model to determine which model to filter on
+            if related_model == "antiquarian":
+                queryset = queryset.filter(antiquarians__id=self.owner_pk)
+            elif related_model == "citing_author":
+                queryset = queryset.filter(citing_authors__id=self.owner_pk)
         return queryset
 
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
-        if self.ant_pk:
-            context["antiquarian"] = Antiquarian.objects.get(id=self.ant_pk)
-        if self.ant_pk:
-            context["antiquarian"] = Antiquarian.objects.get(id=self.ant_pk)
+        related_model = self.kwargs.get("related_model")
+
+        if self.owner_pk:
+            if related_model == "antiquarian":
+                context["antiquarian"] = Antiquarian.objects.get(id=self.owner_pk)
+            elif related_model == "citing_author":
+                context["citingauthor"] = CitingAuthor.objects.get(id=self.owner_pk)
         return context
+
+    def get_template_names(self):
+        related_model = self.kwargs.get("related_model")
+        template_name = f"research/partials/{related_model}_bibliography_list.html"
+        return [template_name]

src/rard/templates/research/citingauthor_detail.html

@@ -145,17 +145,7 @@ <h5>{% trans 'Bibliography' %}</h5>
                 {% endif %}
             </div>
         </div>
-        <div id="bib-list"
-        hx-trigger="refreshed-bibliography from:body, intro-updated from:body"
-        hx-get="{% url 'citingauthor:bibliography' pk=citingauthor.pk %}"
-        hx-swap="outerHTML">
-
-        {% for item in object.bibliography_items.all %}
-
-        {% include 'research/partials/bibliography_list_item.html' with can_edit=perms.research.change_citingauthor has_object_lock=has_object_lock %}
-
-        {% endfor %}
-    </div>
+        {% include 'research/partials/citing_author_bibliography_list.html' with bibliography_items=object.bibliography_items %}
     </section>
 
     {% endwith %}

src/rard/templates/research/partials/citing_author_bibliography_list.html

@@ -0,0 +1,11 @@
+<div id="bib-list"
+hx-trigger="refreshed-bibliography from:body, intro-updated from:body"
+hx-get="{% url 'citingauthor:bibliography' pk=citingauthor.pk %}"
+hx-swap="outerHTML">
+
+{% for item in bibliography_items.all %}
+
+{% include 'research/partials/bibliography_list_item.html' with can_edit=perms.research.change_citingauthor has_object_lock=has_object_lock %}
+
+{% endfor %}
+</div>