Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERV-1172] Add goreleaser and associated files #37

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[SERV-1172] Add goreleaser and associated files #37

merged 3 commits into from
Nov 6, 2024

Conversation

angelahuqing
Copy link
Collaborator

No description provided.

@angelahuqing angelahuqing requested a review from a team as a code owner November 1, 2024 20:32
ksclarke
ksclarke reviewed Nov 4, 2024
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.goreleaser.yaml Show resolved Hide resolved
.goreleaser.yaml Show resolved Hide resolved
@angelahuqing angelahuqing marked this pull request as draft November 5, 2024 16:15
@angelahuqing angelahuqing marked this pull request as ready for review November 5, 2024 18:37
ksclarke
ksclarke reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@ksclarke ksclarke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some text to https://github.com/UCLALibrary/homebrew-festerize 's README that explains what it is.

ksclarke
ksclarke reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@ksclarke ksclarke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add new installation instructions (for Brew) to this project's README, too, I think.

ksclarke
ksclarke reviewed Nov 5, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@angelahuqing angelahuqing merged commit b5290e9 into main Nov 6, 2024
6 checks passed
@angelahuqing angelahuqing deleted the SERV-1172 branch November 6, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRickard DRickard DRickard approved these changes

@ksclarke ksclarke ksclarke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelahuqing @ksclarke @DRickard