-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further object revisions wlpotter #59
base: object-templates-revisions_wlpotter
Are you sure you want to change the base?
Further object revisions wlpotter #59
Conversation
In cases where we want ranges we should keep these as regularized strings (e.g., "15-20" for lines per page)
@@ -32,7 +35,10 @@ | |||
"writing_system": "CV", | |||
"script": "CV", | |||
"ink_color": "CV", | |||
"note": [ | |||
"script_note": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In airtable we distinguish script and hand notes. It may be worth having the two fields: the script note for comments about how the script is used; the hand about specific characteristics of this particular instantiation of the 'ideal' script type.
@@ -48,8 +54,8 @@ | |||
], | |||
"page_layout": [ | |||
{ | |||
"columns": "int", | |||
"number_of_lines": "int", | |||
"columns": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the value constraint for 'columns' and 'number_of_lines' so we can capture cases where there's a range (e.g., "16-20")
"array of strings" | ||
], | ||
"associated_dates": [ | ||
"associated_date": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all in the context of an "events" field, FYI. I think I mostly just reordered the sub-fields.
@@ -77,52 +83,76 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Events deserve their own discussion. I think we'll need to weigh their usefulness and expressiveness as research data points against how difficult it might be to implement for users inputting data about manuscripts.
One option for restructuring this field, which would make it more like 'paratexts' or 'related_objects' would be to have top-level event types:
{
"events":
{
"production": [array of event objects],
"ownership": [array of event objects],
"use": [array of event objects],
"custodianship": [array of event objects]
}
}
"" | ||
], | ||
"attested_entities": { | ||
"paratexts": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated paratexts here in keeping with how we are structuring 'object_relationships' so that there are named top-level paratexts types. We can decide separately what these top-level types might be, but I think that 'colophon' and 'inscriptions' are sufficiently generic to start with.
@@ -160,6 +251,7 @@ | |||
"change": "string describing what change was made?" | |||
} | |||
], | |||
"created": "xsd:dateTime" | |||
"created": "xsd:dateTime", | |||
"delivery": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another field we should have from airtable -- which can also be used like we do currently when checking data on stage by batch number
@@ -7,6 +7,20 @@ | |||
], | |||
"extent": "", | |||
"embodies": "URI of Work Authority File", | |||
"attested_title": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that we are having RAs grab this data but we didn't have anywhere in the JSON to put it...We just had the rubric paratext, which is sometimes more info than we want for the title.
], | ||
"locus": "" | ||
}, | ||
"supplied_title": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is like the 'title from RA' field in our Airtable form. I don't know if we will need this or if we will require users to create an authority record? I like the idea of having a less committal option for titling things (this would be, for example, where we'd put 'unidentified')
@@ -30,52 +44,76 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, on events, see under 'codicological unit'
], | ||
"attested_entities": { | ||
"paratexts": { | ||
"rubric": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this list of top-level types to demonstrate, and based on what we are getting in Airtable. More than happy to add, edit, or delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the list is "rubric", "prologue", "incipit", "explicit", "subscription", and "marginalia". The paratexts field ends on line 554
FYI @kirschbombe These are additional revisions based on the ones made in #52.
Some of these were uncovered in creating 'real data' exemplars (I will make a separate pull request for adding the exemplars).
A few outstanding issues:
I'll make more specific comments and annotations on the files themselves of the changes I've made for discussion