Skip to content

Commit

Permalink
Achieve 100% test coverage for agent_base class (#106)
Browse files Browse the repository at this point in the history
test: Added test for agent base
  • Loading branch information
RickFqt authored Oct 8, 2024
1 parent 830d040 commit a3a1f6b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
13 changes: 13 additions & 0 deletions tests/units/agents/test_agent_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,16 @@ def test_learn(self):

# THEN
assert learn_return is None

def test_learn_with_previous_state(self):
# GIVEN
fake_model = FakeModel()
fake_state_space = FakeState()
fake_agent = FakeAgent(None, fake_state_space, fake_model, None)
fake_agent.previous_state = "previous_state"

# WHEN
learn_return = fake_agent.learn("obs", "reward", "done")

# THEN
assert learn_return is None
2 changes: 1 addition & 1 deletion tests/units/models/test_model_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def __init__(self):

fake_model = FakeModel()
learn_return = fake_model.learn("current_state",
"action", "reward", "next_state")
"action", "reward", "next_state", "done")
predict_return = fake_model.predict("state")
learning_data = fake_model.learning_data

Expand Down
2 changes: 1 addition & 1 deletion urnai/models/model_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def __init__(self):
self.learning_data = {}

@abstractmethod
def learn(self, current_state, action, reward, next_state):
def learn(self, current_state, action, reward, next_state, done):
"""Learning strategy"""
...

Expand Down

0 comments on commit a3a1f6b

Please sign in to comment.