Skip to content

Commit

Permalink
refactor(): Change variable and attribute names
Browse files Browse the repository at this point in the history
  • Loading branch information
RickFqt committed Mar 1, 2024
1 parent 3637b2f commit d7c62cc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions tests/units/states/test_state_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ class FakeState(StateBase):
def __init__(self):
super().__init__()

f = FakeState()
update_return = f.update("observation")
state = f.get_state
dimension = f.get_dimension
reset_return = f.reset()
fake_state = FakeState()
update_return = fake_state.update("observation")
state = fake_state.state
dimension = fake_state.dimension
reset_return = fake_state.reset()
assert isinstance(StateBase, ABCMeta)
assert update_return is None
assert state is None
Expand Down
4 changes: 2 additions & 2 deletions urnai/states/state_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ def update(self, obs) -> List[Any]:

@property
@abstractmethod
def get_state(self):
def state(self):
"""Returns the State currently saved."""
pass

@property
@abstractmethod
def get_dimension(self):
def dimension(self):
"""Returns the dimensions of the States returned by the update method."""
pass

Expand Down

0 comments on commit d7c62cc

Please sign in to comment.