-
Notifications
You must be signed in to change notification settings - Fork 8
Resolves #98 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Resolves #98 #99
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
efcef6f
feat(issue-98): Add SC2Action class
CinquilCinquil bc09fce
test(issue-98): Add units tests to SC2Action
CinquilCinquil 3b6d129
refactor(issue-98): Fix typo in SC2Action unit tests
CinquilCinquil 9332238
refactor(issue-98): Rename action_id to action
CinquilCinquil 2091985
refactor(issue-98): Rename action to action_function
CinquilCinquil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import unittest | ||
|
||
from pysc2.lib import actions | ||
|
||
from urnai.actions.sc2_action import SC2Action | ||
|
||
_BUILD_REFINERY = actions.RAW_FUNCTIONS.Build_Refinery_pt | ||
_NO_OP = actions.FUNCTIONS.no_op | ||
|
||
class TestActionBase(unittest.TestCase): | ||
|
||
def test_run(self): | ||
|
||
run_no_op = SC2Action.run(_NO_OP) | ||
run_build_refinery = SC2Action.run(_BUILD_REFINERY, 'now', 0) | ||
|
||
self.assertEqual(run_no_op.function, _NO_OP.id) | ||
self.assertEqual(run_no_op.arguments, []) | ||
|
||
self.assertEqual(run_build_refinery.function, _BUILD_REFINERY.id) | ||
self.assertEqual(run_build_refinery.arguments, [[actions.Queued['now']], [0]]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from pysc2.lib.actions import FunctionCall | ||
|
||
|
||
class SC2Action: | ||
|
||
"""This class encapsulates the usage of actions from pysc2""" | ||
|
||
def run(action_id, *args) -> FunctionCall: | ||
CinquilCinquil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return action_id(*args) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.