Merged
Conversation
All the Mini House Add-Ons
strattond
previously requested changes
Jan 24, 2025
Contributor
strattond
left a comment
strattond
left a comment
There was a problem hiding this comment.
Minor suggestion, but looks reasonable to me. Haven't done a full box and dice cross-validation of content.
Xoduz
requested changes
Jan 24, 2025
Xoduz
added
Changes Requested
DragonSlayer62
added
Ready for Review
and removed
Changes Requested
Xoduz
added
Changes Requested
DragonSlayer62
added
Ready for Review
and removed
Changes Requested
Xoduz
approved these changes
Jan 28, 2025
Collaborator
There was a problem hiding this comment.
Add origin=aos to the deeds, and add a new section for them (ITEMMENU 261?) in the Deeds section (ITEMMENU 4) of the 'add menu, so they can be found.
Xoduz
dismissed
strattond’s stale review
Requested change (to use GET) is not currently supported and would require a significant code change to support, beyond the scope of this PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the Mini House Add-Ons