Refactored part of flighthistory request #2064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Removed erroneous fields from booking detail history -Adjusted query to consider a date recall limit on how far the history reaches (set to 1 year tentatively), also considers flight direction. -added datetime to history call to pass to new query
| + "left join fetch f.mutableFlightDetails mf " | ||
| + "WHERE (f.direction = 'O' AND mf.etd > :dateLimit) " | ||
| + "OR (f.direction ='I' AND mf.eta > :dateLimit ) " | ||
| + "OR (f.direction = 'A' AND (mf.etd > :dateLimit " |
There was a problem hiding this comment.
f.direction of 'C' should be accounted for as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Removed erroneous fields from booking detail history
-Adjusted query to consider a date recall limit on how far the history reaches (set to 1 year tentatively), also considers flight direction.
-added datetime to history call to pass to new query
fixes #569 on the gtas ui side