Skip to content

Pride Month - Sally Ride #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

lparsons
Copy link
Member

@lparsons lparsons commented Jun 13, 2024

Description

Added Pride Month Celebration Post for Sally Ride

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

@lparsons lparsons force-pushed the pride-month-sally-ride branch from 6f10408 to 2e91339 Compare June 13, 2024 20:30
@lparsons lparsons force-pushed the pride-month-sally-ride branch from 2e91339 to 4c2e694 Compare June 13, 2024 20:32
@lparsons
Copy link
Member Author

@exoticDFT Could you review this PR? I had to rename the file to predate it or it wouldn't build. I also had to avoid linking the file in the main post or it wouldn't build. We can fix that up in a subsequent PR perhaps?

Preview link: https://output.circle-artifacts.com/output/job/90f2b199-8583-46aa-843c-ee662db40910/artifacts/0/usrse.github.io/2024-06-12-pride-spotlight-sally-ride/index.html

Copy link
Member

@exoticDFT exoticDFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really want to delay this for what seems to be a fairly silly thing, but I just tried to view this on my phone and the image kind of interrupts the text significantly. Landscape mode seems totally fine, so I assume a PC monitor would too. Does our image include allow for cropping an image to a square ratio when the view is mobile?

Also, maybe more important. Did we want to update the main post with these community posts like we did last year and with Black History Month?

Screenshot_20240613-182115.png

@lparsons
Copy link
Member Author

I wasn't able to replicate the issue your having with the image, but I believe it's more of a "site-wide" issue, and thus I don't think it should hold up this post.

I was unable to create the link on the Pride Month post since that caused the entire Jekyl build to fail, claiming the page didn't exist. Happy to add that is a separate PR (or this one if someone knows how to do it).

image
image

@mrmundt
Copy link
Contributor

mrmundt commented Jun 14, 2024

@lparsons - As long as you are linking it as a relative url (e.g., {{ site.baseurl }}/path/to/whatever ), Jekyll shouldn't complain.

@lparsons
Copy link
Member Author

@lparsons - As long as you are linking it as a relative url (e.g., {{ site.baseurl }}/path/to/whatever ), Jekyll shouldn't complain.

Internal links typically use the post_url tag, which did not work for me.

@exoticDFT
Copy link
Member

Interesting. I guess my phone's resolution is just slightly wider than yours. I do think it's a site-wide problem, so we can ignore that. If you're having issues with the internal post as well, let's just ignore that for later. I'll approve the PR so we can merge

Copy link
Member

@exoticDFT exoticDFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exoticDFT exoticDFT merged commit 96ae6e8 into USRSE:main Jun 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants