-
Notifications
You must be signed in to change notification settings - Fork 93
Pride Month - Sally Ride #1519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pride Month - Sally Ride #1519
Conversation
6f10408
to
2e91339
Compare
2e91339
to
4c2e694
Compare
@exoticDFT Could you review this PR? I had to rename the file to predate it or it wouldn't build. I also had to avoid linking the file in the main post or it wouldn't build. We can fix that up in a subsequent PR perhaps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really want to delay this for what seems to be a fairly silly thing, but I just tried to view this on my phone and the image kind of interrupts the text significantly. Landscape mode seems totally fine, so I assume a PC monitor would too. Does our image include allow for cropping an image to a square ratio when the view is mobile?
Also, maybe more important. Did we want to update the main post with these community posts like we did last year and with Black History Month?
I wasn't able to replicate the issue your having with the image, but I believe it's more of a "site-wide" issue, and thus I don't think it should hold up this post. I was unable to create the link on the Pride Month post since that caused the entire Jekyl build to fail, claiming the page didn't exist. Happy to add that is a separate PR (or this one if someone knows how to do it). |
@lparsons - As long as you are linking it as a relative url (e.g., |
Internal links typically use the |
Interesting. I guess my phone's resolution is just slightly wider than yours. I do think it's a site-wide problem, so we can ignore that. If you're having issues with the internal post as well, let's just ignore that for later. I'll approve the PR so we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added Pride Month Celebration Post for Sally Ride
Checklist:
When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.