[Do-not-merge] PIM API fusion initial support #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you so much @deyuan! |
Morteza1814
reviewed
Apr 11, 2025
fasiddique
reviewed
Apr 13, 2025
Collaborator
There was a problem hiding this comment.
Another test case should be overwriting the PIMobject data and pushing it to pim prog and pim prog should not fuse those. Just a sanity check! :)
deyuan
changed the title
fasiddique
approved these changes
Apr 30, 2025
Collaborator
fasiddique
left a comment
fasiddique
left a comment
There was a problem hiding this comment.
@deyuan I am fine with merging this to the main branch considering this does not interfere with the existing model. Thank you again!
Collaborator
|
Merging this to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very preliminary solution to support PIM API fusion with correct functional simulation results.
Usage example (see test-api-fusion):
PimProg prog;
prog.add(pimMulScalar, objSrc1, objDest1, static_cast<uint64_t>(scalarVal));
prog.add(pimAdd, objDest1, objSrc2, objDest1);
status = pimFuse(prog);
It requires further work to recognize fusion opportunities among APIs and parameters and update performance accordingly in pimCmd. @fasiddique @Morteza1814 @khyatikiyawat Please feel free to comment or propose any alternative solutions.