Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide_keycloak.rst #1760

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

christianstrauch
Copy link

Updated for Keycloak 24.0.3

Updated for 24.0.3
Re-added original author
@SalocinHB SalocinHB self-assigned this May 29, 2024
Copy link
Member

@SalocinHB SalocinHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling that you deleted too much from the original guide without providing a reason. Was this by mistake or did you mean to replace these sections?

[isabell@stardust ~]$ kill -SIGKILL PID
[isabell@stardust ~]$

Run the upgrade script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more upgrade/update instructions? why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide some feedback to these questions? Otherwise, we'll close this PR next month.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had removed everything that, in its former form, does not apply to the newest Keycloak version any more. We need to completely rewrite the update guide. So far, my intention was to ensure the installation steps are properly reflected as they had to change quite dramatically, and that everything that would break any new installation is removed.

@nichtmax nichtmax marked this pull request as draft May 29, 2024 12:51
@SalocinHB SalocinHB removed their assignment Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants