Adding mig mutating webhook sources #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mynktl
reviewed
Nov 12, 2025
| kind: MutatingWebhookConfiguration | ||
| metadata: | ||
| annotations: | ||
| kubectl.kubernetes.io/last-applied-configuration: | |
Collaborator
There was a problem hiding this comment.
lets remove this as not required
| @@ -0,0 +1 @@ | |||
| Initial commit mig mutating webhook | |||
Collaborator
There was a problem hiding this comment.
please add instruction explaining why/ -- how to deploy/use it
Comment on lines
+41
to
+43
| if key == "ca.crt" { | ||
|
|
||
| caPEM = value |
Collaborator
There was a problem hiding this comment.
Suggested change
| if key == "ca.crt" { | |
| caPEM = value | |
| if key == "ca.crt" { | |
| caPEM = value |
same at other places
| clientTLSCert = &tls.Config{RootCAs: certpool} | ||
|
|
||
| } else { | ||
|
|
Collaborator
There was a problem hiding this comment.
better to have a separate function to generate cert
|
|
||
| k8sSecretsClient = k8sclientset.CoreV1().Secrets(currentNamespace) | ||
|
|
||
| ctx = context.Background() |
Collaborator
There was a problem hiding this comment.
nit: usually context is declared at top and passed down to child functions whenever required
|
|
||
| ctx = context.Background() | ||
|
|
||
| _, err = k8sSecretsClient.Get(ctx, "migmutatingwebhook-tls", metav1.GetOptions{}) |
Collaborator
There was a problem hiding this comment.
use constant for "migmutatingwebhook-tls"
|
|
||
| func CreateCertSecret(serverCert, serverKey, caCert string) { | ||
|
|
||
| kuebConfigFilePath := filepath.Join("/etc", "rancher", "rke2", "rke2.yaml") |
Collaborator
There was a problem hiding this comment.
instead of using rke2.yaml we can either use config from KUBECONFIG or in cluster config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sources for mutating webhook to allow the usage of mixed profile MIG gpus in AI Center pipelines.