Skip to content

CuraApplication.py add startReloadAll signal when reloadAll is called #19608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dfries
Copy link
Contributor

@dfries dfries commented Sep 3, 2024

Description

Uranium/UM/Scene/Scene.py commit "Scene.py add _hideReloadMessage, connect to startReloadAll" Uranium pull request Ultimaker/Uranium#964 depends on this commit and the signal startReloadAll, which it will
use to cancel file modification reload dialog. Once all the models
are reloaded, the file modification reload dialog is not needed.

Type of change

  • New feature (non-breaking change which adds functionality) I could argue this is a bug.

How Has This Been Tested?

  • Exercise F5 reloadAll
  1. Load a set of models
  2. Externally modify a file
  3. Verify "File has been modified" dialog shows, don't click it
  4. Press F5, verify the new model shows and "File has been modified" dialog hides

Test Configuration:

  • Operating System: Debian Linux

Checklist:

Uranium/UM/Scene/Scene.py depends this startReloadAll, which it will
use to cancel file modification reload dialog.  Once all the models
are reloaded, the file modification reload is not needed.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Sep 3, 2024
@HellAholic HellAholic changed the base branch from 5.8 to main June 27, 2025 07:15
@wawanbreton
Copy link
Contributor

Hi @dfries, thanks for this change !
It looks overall good, however you are adding the startReloadAll signal in Cura, and using it in Uranium. Technically, Uranium is a standalone library (even though it is nowadays more of an integral part of Cura), and you are creating a dependency from Uranium to Cura, which is not allowed. Could you move this signal to QtApplication, which is part of Uranium ?

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Test Results

23 953 tests  ±0   23 951 ✅ ±0   47s ⏱️ -1s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 44c5788. ± Comparison against base commit 4e04d06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants