-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
InsertAtLayerChange: Make the conversion to uppercase optional #20444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add the option type bool - Set to be enabled by default - Add condition to only convert if bool value is true
For all the myriad settings I stick into things it never occurred to me to add this. I thought about no uppercase, but Marlin doesn't read lowercase commands. The only reason I put the "upper" in there was to catch typos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a question
Add an option to allow users to not convert to uppercase.
Add the option type bool
Set to be enabled by default
Add condition to only convert if bool value is true
New feature (non-breaking change which adds functionality)
Solves: #20441