Remove unused hack

[ratijas]

Description

Introduced back in 798c1f1 and unused since 5992e66, this is no longer an appropriate way to perform type checks in QML by modern Qt standards. Just use instanceof operator instead, if needed; it works since Qt 5.10

Source: https://doc.qt.io/qt-6/qtqml-javascript-hostenvironment.html

Type of change

• Chore/cleanup

How Has This Been Tested?

• Search for the function name in all project files, find none.

Checklist:

• My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
• I have read the Contribution guide
• I have commented my code, particularly in hard-to-understand areas
• I have uploaded any files required to test this change

[github-actions]

Test Results

23 783 tests  ±0   23 781 ✅ ±0   46s ⏱️ -1s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit b09a42c. ± Comparison against base commit 43a055c.

[fieldOfView]

Strictly speaking, removing this function constitutes a major SDK version change, which is a pain because it means that all Marketplace plugins (whether they use the function or not) need to be changed and resubmitted.

Please see if there is a way to keep the function, but make it use the instanceof operator under the hood. Bonus points: have it emit a deprecation warning, though I don't remember if there's a generic way to do that from QML.

[ratijas]

Strictly speaking, removing this function constitutes a major SDK version change, which is a pain because it means that all Marketplace plugins (whether they use the function or not) need to be changed and resubmitted.

Oh, I was under an impression that it was some kind of entry point for the whole application like what would be main.qml in some other projects. Is it a piece of library with external API? (Irrelevant, but it was also literally just the first file I opened in the workspace while searching for .qml components.)

Please see if there is a way to keep the function, but make it use the instanceof operator under the hood. Bonus points: have it emit a deprecation warning, though I don't remember if there's a generic way to do that from QML.

No can do. The function expects a string, but you can't just resolve a string back to a type that it represents. Unfortunately, as of Qt 6.10 QML still lacks any sort of dedicated deprecation syntax/API either, you'd just have to console.warn() or something.

[fieldOfView]

Points taken. Then it is up to the Cura team to decide if this is minor enough to skip the SDK version update. To be honest, I don't know if any plugin is using the call from their QML.

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

• resources/qml/Cura.qml: Language not supported

[ratijas]

Sooo… now what?

If it's gonna stuck forever, I'd rather just close and delete the branch honestly.