Skip to content

Update PurgeLinesAndUnload.py #20660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025
Merged

Update PurgeLinesAndUnload.py #20660

merged 4 commits into from
Jun 16, 2025

Conversation

HellAholic
Copy link
Contributor

@HellAholic HellAholic commented Jun 5, 2025

Fixes an exception thrown upon a clean start.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Clean start on 5.10.1 -> No exception thrown
  • Validate output of the script remains the same - No exceptions when script executed.

Test Configuration:

  • Operating System: Windows 11

Fixes an exception thrown upon a clean start.
@HellAholic HellAholic added PR: Community Contribution 👑 Community Contribution PR's PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor labels Jun 5, 2025
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Test Results

23 881 tests  ±0   23 879 ✅ ±0   46s ⏱️ -1s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 44e1c08. ± Comparison against base commit ee021f7.

♻️ This comment has been updated with latest results.

@jellespijker jellespijker requested a review from Copilot June 9, 2025 16:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an exception thrown on a clean start by refactoring the initialization method in PurgeLinesAndUnload.py.

  • Introduces a new initialize() method that calls super().initialize() and sets up the global stack.
  • Removes a duplicate initialize() definition to consolidate initialization logic.
Comments suppressed due to low confidence (2)

plugins/PostProcessingPlugin/scripts/PurgeLinesAndUnload.py:42

  • Using super().initialize() in the new initialize() method is appropriate; please verify that all necessary base class initialization requirements are met.
super().initialize()

plugins/PostProcessingPlugin/scripts/PurgeLinesAndUnload.py:41

  • The duplicate initialize() method has been removed. Please confirm that any initialization logic previously handled in the removed block has been fully integrated into the new method.
def initialize(self) -> None:

Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe a some point we should update SearchAndReplace.py (which is referenced as being the example plugin) so that it also has a basic overridden initialize function

@wawanbreton wawanbreton merged commit 985591f into main Jun 16, 2025
4 checks passed
@wawanbreton wawanbreton deleted the Update-PurgeAndUnload.py branch June 16, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants