Skip to content

Workflow fixes #20693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

Workflow fixes #20693

merged 3 commits into from
Jun 16, 2025

Conversation

HellAholic
Copy link
Contributor

Description

Adjustment to the workflow files:

  • path -> paths: The correct keyword for filtering pull request triggers by file paths is paths (plural), not path (singular).
  • indentation fix: with keyword should be on the same indent level as uses.

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)

The correct keyword for filtering pull request triggers by file paths is paths (plural), not path (singular).
@HellAholic HellAholic added PR: Community Contribution 👑 Community Contribution PR's PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor labels Jun 15, 2025
@HellAholic HellAholic requested a review from Copilot June 15, 2025 14:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes workflow issues by updating the pull request trigger keyword and adjusting the indentation in the workflow file.

  • Updated workflow file filtering keyword from "path" to "paths".
  • Adjusted indentation for consistency in the workflow file.

@HellAholic HellAholic added the PR: Automation and build 🤖 Improving CI/CT/CD workflows label Jun 15, 2025
@@ -2,7 +2,7 @@ name: printer-linter-pr-diagnose

on:
pull_request:
path:
paths:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😄

Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (did a first review but read the diff backwards, sorry 👼)

@wawanbreton wawanbreton merged commit ea20cb2 into main Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Automation and build 🤖 Improving CI/CT/CD workflows PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants