Absolute value of real numbers#1385
Merged
fredrik-bakke merged 100 commits intoUniMath:masterfrom Mar 27, 2025
Merged
Conversation
fredrik-bakke
approved these changes
Mar 26, 2025
Co-authored-by: Fredrik Bakke <[email protected]>
fredrik-bakke
approved these changes
Mar 26, 2025
Collaborator
fredrik-bakke
left a comment
There was a problem hiding this comment.
Very good! I'll enable auto-merge so that the PR (hopefully) will merge immediately after you resolve the final comments
Co-authored-by: Fredrik Bakke <[email protected]>
auto-merge was automatically disabled
March 27, 2025 02:09
Head branch was pushed to by a user without write access
Collaborator
Author
|
Doesn't look like that works, unfortunately. |
Collaborator
|
Sorry, looks like I placed the apostrophe in the wrong spot in one of my suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't have nearly as much content as #1381 , but that's because we don't even have addition yet on the real numbers. Still, this is, I think, enough to continue on #1353 .