Romps 2017 Analytic LCL #3728
Merged
Romps 2017 Analytic LCL #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcamron
added
Type: Enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
A summary of some super quick benchmarks across commits via ASV Note that #3726 currently seems to slow |
dcamron
force-pushed
the
analytic-lcl
branch
2 times, most recently
from
16cbb32 to
f75f3d0
Compare
dopplershift
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #3726 and #3725. Adds direct calculation for LCL from Romps 2017, with relatively small test value impact and large impact on performance. Also removes now-unused params for LCL.
I will create a new issue to add LDL. I'll update the thread below with near-final local benchmark results, and look to capture more detailed benchmarks on the docs once we decide how we want that to look.
Checklist