Flag (false by default) to restrict D2D communication of LtePhUeD2D to the cell the node is in #266
+165
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
host instead of kvm, seems that kvm leads to different fingerprints in five tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small patch adds a new flag (d2dEnforceEnbBoundOnSideLink , by default turned off) to LtePhyUeD2D. If enabled, it restricts D2D sidelink communication of a node to the cell the node is in. This can be used to model a (worst-case, since resources are still shared) scenario where nodes cannot communicate with other nodes via D2D if they are managed by different base stations.
Beyond this small new feature, the pull request also includes several other commits with small improvements (hope it's ok to include it here for simplicity, we can also submit separate pull requests):
a) Bugfix for MAC throughput calculation: in src/stack/mac/buffer/harq/LteHarqBufferRx.h a single static variable was used to sum up all received bytes. This is ok, if we have a scenario with a single base station - however, with multiple base stations, all base stations will add to this single static variable, leading to incorrect values reported for throughput. Please not that since now packet events and the throughput(...) calculation is used, the unit has also changed from Byte/s (Bps) to bits/s (bps).
b) add a new statistic "macNodeId" which reports the MacId assigned to a node by the binder
c) Fixes to log messages in LteAmc: misleading logs in LteAmc.cc are correct now.
d) Updated fingerprints (needed since we add new statistics, etc.)
Comments & suggestions always welcome.
Thank you again for Simu5G & making it publicly available!
Lars