Skip to content

refactor(v3-sdk): simplify midPrice in Route entity #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shuhuiluo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(v3-sdk): simplify midPrice in Route entity #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 3 additions & 22 deletions sdks/v3-sdk/src/entities/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,28 +61,9 @@ export class Route<TInput extends Currency, TOutput extends Currency> {
public get midPrice(): Price<TInput, TOutput> {
if (this._midPrice !== null) return this._midPrice

const price = this.pools.slice(1).reduce(
({ nextInput, price }, pool) => {
return nextInput.equals(pool.token0)
? {
nextInput: pool.token1,
price: price.multiply(pool.token0Price),
}
: {
nextInput: pool.token0,
price: price.multiply(pool.token1Price),
}
},
this.pools[0].token0.equals(this.input.wrapped)
? {
nextInput: this.pools[0].token1,
price: this.pools[0].token0Price,
}
: {
nextInput: this.pools[0].token0,
price: this.pools[0].token1Price,
}
).price
const price = this.pools.slice(1).reduce((price, pool) => {
return price.multiply(pool.priceOf(price.quoteCurrency))
}, this.pools[0].priceOf(this.input.wrapped))

return (this._midPrice = new Price(this.input, this.output, price.denominator, price.numerator))
}
Expand Down
Loading