Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permit2-sdk): separate cjs and esm builds, remove tsdx #220

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

just-toby
Copy link
Collaborator

@just-toby just-toby commented Dec 16, 2024

PR Scope

breaking change to build structure for permit2-sdk

Description

updates the build setup for permit2-sd to manually and explicitly create separate cjs and esm builds (plus a types-only version)

How Has This Been Tested?

built the sdk locally, then installed the local build result in another project (universe/apps/web) and verified that it properly resolved the esm version instead of the cjs version

Are there any breaking changes?

there shouldn't be, but technically if an end user is importing incorrectly (by directly referencing any build artifact files) then they'll need to update

(Optional) Follow Ups

PRs to follow will do this for many other SDKs

Copy link
Collaborator Author

just-toby commented Dec 16, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@just-toby just-toby requested a review from adjkant December 16, 2024 17:23
@just-toby just-toby marked this pull request as ready for review December 16, 2024 17:23
@just-toby just-toby requested review from jsy1218 and a team as code owners December 16, 2024 17:23
@just-toby just-toby force-pushed the feat/uniswapx-sdk-esm-build branch from bb5c9f8 to 1759d4c Compare December 16, 2024 21:57
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from d061f25 to aac8085 Compare December 16, 2024 21:57
@just-toby just-toby force-pushed the feat/uniswapx-sdk-esm-build branch from 1759d4c to 7cea2d9 Compare December 16, 2024 22:45
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from aac8085 to 73d5b8b Compare December 16, 2024 22:45
@just-toby just-toby force-pushed the feat/uniswapx-sdk-esm-build branch from 7cea2d9 to 4973c99 Compare December 16, 2024 23:04
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from 73d5b8b to f2c31ef Compare December 16, 2024 23:05
@just-toby just-toby force-pushed the feat/uniswapx-sdk-esm-build branch from 4973c99 to c4941d1 Compare December 16, 2024 23:06
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from f2c31ef to 4781fa9 Compare December 16, 2024 23:07
@just-toby just-toby force-pushed the feat/uniswapx-sdk-esm-build branch from c4941d1 to 3bc5140 Compare December 16, 2024 23:24
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from 4781fa9 to c0a6a1d Compare December 16, 2024 23:24
Copy link

graphite-app bot commented Dec 16, 2024

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/16/24)

1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@just-toby just-toby changed the base branch from feat/uniswapx-sdk-esm-build to graphite-base/220 December 18, 2024 17:49
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from c0a6a1d to 4fc3bee Compare December 18, 2024 17:49
@just-toby just-toby changed the base branch from graphite-base/220 to main December 18, 2024 17:50
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from 4fc3bee to 9311793 Compare December 18, 2024 17:50
Copy link
Collaborator

@adjkant adjkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues I can see here!

@adjkant
Copy link
Collaborator

adjkant commented Feb 26, 2025

@just-toby given the case of breakage I'm okay with a minor version bump here, though defer to others if we prefer a major here!

@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from 9311793 to 03bde4b Compare February 27, 2025 17:56
@just-toby just-toby requested a review from a team as a code owner February 27, 2025 17:56
Copy link
Member

jsy1218 commented Feb 27, 2025

its just do a minor version bump to avoid potential hassles

@just-toby just-toby changed the base branch from main to graphite-base/220 February 27, 2025 19:36
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from 03bde4b to 6a06ad5 Compare February 27, 2025 19:36
@just-toby just-toby changed the base branch from graphite-base/220 to feat/v4-sdk-build February 27, 2025 19:36
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from 6a06ad5 to 085cdd4 Compare February 27, 2025 19:43
@just-toby just-toby force-pushed the feat/permit2-sdk-build branch from 085cdd4 to 593b3e7 Compare February 27, 2025 19:50
Copy link
Collaborator Author

just-toby commented Feb 27, 2025

Merge activity

@just-toby just-toby changed the base branch from feat/v4-sdk-build to graphite-base/220 February 27, 2025 21:51
@just-toby just-toby merged commit b089e99 into graphite-base/220 Feb 27, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants