-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permit2-sdk): separate cjs and esm builds, remove tsdx #220
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bb5c9f8
to
1759d4c
Compare
d061f25
to
aac8085
Compare
1759d4c
to
7cea2d9
Compare
aac8085
to
73d5b8b
Compare
7cea2d9
to
4973c99
Compare
73d5b8b
to
f2c31ef
Compare
4973c99
to
c4941d1
Compare
f2c31ef
to
4781fa9
Compare
c4941d1
to
3bc5140
Compare
4781fa9
to
c0a6a1d
Compare
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/16/24)1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
c0a6a1d
to
4fc3bee
Compare
3bc5140
to
b25a2de
Compare
4fc3bee
to
9311793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues I can see here!
@just-toby given the case of breakage I'm okay with a minor version bump here, though defer to others if we prefer a major here! |
9311793
to
03bde4b
Compare
its just do a minor version bump to avoid potential hassles |
03bde4b
to
6a06ad5
Compare
6a06ad5
to
085cdd4
Compare
dbe47ef
to
244a357
Compare
085cdd4
to
593b3e7
Compare
244a357
to
d2163a1
Compare
593b3e7
to
b87b322
Compare
d2163a1
to
8fbffe3
Compare
Merge activity
|
PR Scope
breaking change to build structure for
permit2-sdk
Description
updates the build setup for
permit2-sd
to manually and explicitly create separate cjs and esm builds (plus a types-only version)How Has This Been Tested?
built the sdk locally, then installed the local build result in another project (
universe/apps/web
) and verified that it properly resolved the esm version instead of the cjs versionAre there any breaking changes?
there shouldn't be, but technically if an end user is importing incorrectly (by directly referencing any build artifact files) then they'll need to update
(Optional) Follow Ups
PRs to follow will do this for many other SDKs