feat(router-sdk): bump sdk-core to 7.2.0 for arb, base, polygon #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
force-pushed
the
siyujiang/router-sdk-sdk-core-7.2.0
branch
from
5437d64 to
6a3e15b
Compare
jsy1218
force-pushed
the
siyujiang/router-sdk-sdk-core-7.2.0
branch
from
55b58a9 to
f714d6a
Compare
cgkol
approved these changes
Jan 21, 2025
jsy1218
commented
Jan 21, 2025
| @@ -288,7 +288,6 @@ describe('Command Parser', () => { | |||
| zeroForOne: true, | |||
| amountIn: amount, | |||
| amountOutMinimum: amount, | |||
| sqrtPriceLimitX96: BigNumber.from(0), | |||
There was a problem hiding this comment.
@hensha256 @dianakocsis @snreynolds FYI, removing this test data setup could make test pass. I have to do it for now to unblock trading-api as well as FE. '
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (01/21/25)1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
jsy1218
added a commit
that referenced
this pull request
Jan 22, 2025
## Description Release #253 ## How Has This Been Tested? _[e.g. Manually, E2E tests, unit tests, Storybook]_ ## Are there any breaking changes? _[e.g. Type definitions, API definitions]_ If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title `feat(breaking): ...`), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK. ## (Optional) Feedback Focus _[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]_ ## (Optional) Follow Ups _[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release #252 #251 #250 #249
How Has This Been Tested?
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.(Optional) Feedback Focus
[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]