Gas Griefing Vulnerability when withdrawing native ETH #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "fill on targetChain first, claim on origin later" workflow using TheCompact, ensuring solvers can successfully claim resource-locked funds is critical.
A vulnerability arises when claiming ETH as the underlying asset: if any recipient in a split claim implements a gas-griefing or reentrant receive function, it could block the entire split claim process. This would prevent all other recipients in the split from receiving their funds, even if only one recipient acts maliciously.
I suggest adding a gas stipend:
Note: This PR is currently a draft because I’m uncertain whether this fix might introduce unintended side effects. I’d greatly appreciate feedback on the approach and potential risks.