L1 staking #22
Merged
L1 staking #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongeric
reviewed
Mar 17, 2025
Comment on lines
13
to
17
| struct AccessControl { | ||
| bool acceptDelegation; | ||
| address authorizedSender; | ||
| IDelegatorVerifier verifier; | ||
| } |
There was a problem hiding this comment.
nit: would prefer this to be in a library if used in other contracts
There was a problem hiding this comment.
not used in any other contracts, this is just internal storage
|
|
||
| /// @inheritdoc IDelegatorAccessControl | ||
| function setDelegationStatus(bool status) external { | ||
| _delegatorAccessControl[msg.sender].acceptDelegation = status; |
There was a problem hiding this comment.
calling msg.sender directly is cheaper than caching it in a variable, or is this about readability instead of gas?
There was a problem hiding this comment.
Oh for some reason I thought it was cheaper if used multiple times huh, I don't mind then. For larger functions def prefer for readability
There was a problem hiding this comment.
It's true for things like .length when the array is in memory
* Create base L1TestHandler * remove solmate * imports * Add deployer to compile without IR and speed up compilation by 50% --------- Co-authored-by: gretzke <[email protected]>
* initial staking middleware params tests * add a few more tests
* add delegator access control tests * fix shadowed variable * use selectors from interfaces to test reverts --------- Co-authored-by: gretzke <[email protected]>
* ProtocolRewardDistributor tests * remove console.log, formatting --------- Co-authored-by: gretzke <[email protected]>
* Create base L1TestHandler * remove solmate * imports * tests first pass * Add tests * clean up tests * name * Test/stake manager proposed changes (#49) * No need to add these functions here * Rename Wrapper => Harness to align with the naming used in other tests * move delegator to L1 Handler --------- Co-authored-by: Daniel Gretzke <[email protected]>
* Add explanation for added function to interface * clarify logic flow of allowing delegation * Add natspec * make functions and variables internal in Votes, extend functionality in OperatorVotes * add multicall to contract
* Initial commit: OperatorManager tests * Overwrite public function instead of internal function * rename internal functions * cache msg.sender * remove unused import * rename variable
* Add some fuzz tests * Add invariant tests * Add slashing to invariant tests * comments * nit * move file to StakingMiddleware directory --------- Co-authored-by: gretzke <[email protected]>
* Simplify logic around slashing and add more comments * Add fuzz and invariant to stake manager (#51) * Add some fuzz tests * Add invariant tests * Add slashing to invariant tests * comments * nit * move file to StakingMiddleware directory --------- Co-authored-by: gretzke <[email protected]> * Simplify logic around slashing and add more comments * Add SlashingManager tests --------- Co-authored-by: Eric Zhong <[email protected]>
* require stake to deposit into UniStaker, add view function to check whether user is deposited into unistaker * add unistaker wrapper tests
* Initial commit: Notifier * Notification implementation * Add forceful withdrawals of ERC-721 tokens for operators * Update documentation * Initial commit: Stake Table Sync * fix merge conflicts * fix contract size, fix stack too deep in tests * Add notifier tests * remove duplicate remappings * Add staketablesync tests * Add trusted service contracts * check header of 7702 smart wallets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.