Fix tests for Foundry Stable #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Mar 31, 2025
test/ERC6909Claims.t.sol
Outdated
| function test_revertTransferFromBalanceOverflow(address sender, address receiver, uint256 id, uint256 amount) | ||
| public | ||
| { | ||
| vm.assume(sender != receiver); |
There was a problem hiding this comment.
generally prefer an if statement instead of assume because of fuzzing erroring sometimes for too many assumes
hensha256
reviewed
Mar 31, 2025
test/ERC6909Claims.t.sol
Outdated
| vm.prank(sender); | ||
| token.transfer(receiver, id, amount); | ||
| } | ||
|
|
||
| function testFailTransferBalanceOverflow(address sender, address receiver, uint256 id, uint256 amount) public { | ||
| function test_revertTransferBalanceOverflow(address sender, address receiver, uint256 id, uint256 amount) public { | ||
| vm.assume(sender != receiver); |
hensha256
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
CI busted because foundry stable has breaking changes related to tests
Description of changes
Added
allow_internal_expect_revert = trueto the toml (migration guide)Moved
testFail*functions totest_revert*+ vm.expectRevert (migration guide)also
actions/cache@v2in the lint CI was deprecated so bumped that version