Skip to content

Add certora verification specs #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add certora verification specs #969

wants to merge 1 commit into from

Conversation

ccashwell
Copy link
Member

Description of changes

This adds Certora's formal verification specs to the v4-core repo with no changes to any Uniswap code or the build pipeline.

@ccashwell ccashwell requested a review from a team as a code owner April 21, 2025 13:36
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if this should live in tests/ actually?

Happy to merge though!

@ccashwell
Copy link
Member Author

@snreynolds I feel like having it in tests/ is wrong because it's not going to run without external tooling (which isn't documented anywhere in the repo and seems like a side quest), plus much of the Solidity code included here is either mocks or simplifications of existing logic which imo would increase confusion if analyzed within the same context as the actual test suite. My view is that the FV files should be segregated from the main code and tests for clarity if nothing else.

@Ericak31
Copy link

Amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants