Conversation
Collaborator
matteenm
commented
Aug 27, 2024
matteenm
commented
- use new contract
- save new sqrtPrice and ticket fields emitted from initialize event as part of Pool entity.
- update tests to test for new saved fields
mzywang
approved these changes
Aug 27, 2024
Collaborator
Author
|
There's gonna be a new PoolManager deployment soon, and each deployment requires routing to make updates on their end to reflect new addresses of various V4-related contracts. So gonna hold off on merging this for now. Likely going to wait for the next PoolManager deployment, update code to use that, and merge/deploy that version instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.