Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Java 8 for contest estimator #1711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable Java 8 for contest estimator #1711

wants to merge 1 commit into from

Conversation

denis-fokin
Copy link
Collaborator

@denis-fokin denis-fokin commented Jan 18, 2023 •
edited
Loading

Description

SBST competition requires us generating and running tests with Java 8. While it seems reasonable to switch JAVA_HOME to Java 8, it will break others projects. We have to switch only the project specific to tests generated by the contest estimator.

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Regression and integration tests

Local run

Automated Testing

CI run

Manual Scenario

  1. Specify path to Java 8 rt.jar in gradle.properties (jdk8Jar)
  2. Run contest estimator for spoon project
  3. Execute :utbot-junit-contest:test task
  4. Check that IDE shows test run results

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@denis-fokin denis-fokin force-pushed the denis-fokin/enable_java8_for_contest_estimator branch 2 times, most recently from 3b71523 to 7fb91a8 Compare January 18, 2023 15:46
@denis-fokin denis-fokin marked this pull request as draft January 18, 2023 15:55
@denis-fokin denis-fokin force-pushed the denis-fokin/enable_java8_for_contest_estimator branch from 7fb91a8 to e780dbc Compare January 19, 2023 07:17
@denis-fokin denis-fokin force-pushed the denis-fokin/enable_java8_for_contest_estimator branch from e780dbc to 4da0d67 Compare January 19, 2023 08:45
@denis-fokin denis-fokin marked this pull request as ready for review January 19, 2023 08:46
@Domonion Domonion mentioned this pull request Jan 23, 2023
Open
@alisevych alisevych added ctg-enhancement New feature, improvement or change request comp-contest-estimator Issue is related to contest estimator labels Jan 24, 2023
Domonion
Domonion requested changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@Domonion Domonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes does not bring JDK 8 to Contest Estimator, see Issues tree from #1736. I think its worth adding this changes without jdk8Jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Domonion Domonion Domonion requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
comp-contest-estimator Issue is related to contest estimator ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-fokin @Domonion @alisevych